Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP

From: Borislav Petkov
Date: Tue Nov 08 2016 - 16:09:04 EST


On Tue, Nov 08, 2016 at 09:39:02PM +0100, Thomas Gleixner wrote:
> That does not make any sense. Where is m.tsc initialized? I couldn't find
> any place which does, except this and the conditional clear farther down in
> that function.

mce_gather_info->mce_setup does

m->tsc = rdtsc();

And we do that *everytime* but then we go and clear the damn thing. I
know, I know, I wanted to flip that logic too and read the TSC *only*
when we want a precise timestamp but that would require more changes as
mce_setup() is used at a bunch of places.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.