Re: [PATCH] leds: Add mutex protection in brightness_show()
From: Pavel Machek
Date: Wed Nov 09 2016 - 07:38:08 EST
Hi!
> Initially the claim about no need for lock in brightness_show()
> was valid as the function was just returning unchanged
> LED brightness. After the addition of led_update_brightness() this
The claim was probably wrong from the day one, unless brightness is of
type "atomic_t".
/* Ensures consistent access to the LED Flash Class device */
struct mutex led_access;
};
This should really list fields that are protected by led_access.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature