Re: [PATCH 2/4] perf hist browser: Show folded sign properly on --hierarchy

[Arnaldo Carvalho de Melo]

Em Wed, Nov 09, 2016 at 11:28:11AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 08, 2016 at 10:08:31PM +0900, Namhyung Kim escreveu:
> > When horizontall scrolling is used in hierarchy mode, the folded signed
> > disappears at the right most column.
> 
> Humm, this indeed shows the '+' folded signal after pressing ->, but it
> moves from the first to the third column :-\
> 
> > +++ b/tools/perf/ui/browsers/hists.c
> > @@ -1381,8 +1381,14 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser,
> >  		}
> >  
> >  		perf_hpp_list__for_each_format(entry->hpp_list, fmt) {
> > -			ui_browser__write_nstring(&browser->b, "", 2);
> > -			width -= 2;

Also why move this invariant to both branches?

> > +			if (first) {
> > +				ui_browser__printf(&browser->b, "%c ", folded_sign);
> > +				width -= 2;
> > +				first = false;
> > +			} else {
> > +				ui_browser__write_nstring(&browser->b, "", 2);
> > +				width -= 2;
> > +			}
> >  
> >  			/*
> >  			 * No need to call hist_entry__snprintf_alignment()
> > -- 
> > 2.10.1