Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory
From: Balbir Singh
Date: Wed Nov 09 2016 - 19:56:30 EST
On 08/11/16 10:44, Reza Arbab wrote:
> When movable nodes are enabled, any node containing only hotpluggable
> memory is made movable at boot time.
>
> On x86, hotpluggable memory is discovered by parsing the ACPI SRAT,
> making corresponding calls to memblock_mark_hotplug().
>
> If we introduce a dt property to describe memory as hotpluggable,
> configs supporting early fdt may then also do this marking and use
> movable nodes.
This looks much better, like the other comments pointed out
We need documentation around the changes. One quick question
Have you tested this across all combinations of skiboot/kexec/SLOF boots?
Balbir Singh.