Re: [PATCH] net: mii: report 0 for unknown lp_advertising
From: David Miller
Date: Wed Nov 09 2016 - 20:27:29 EST
From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 8 Nov 2016 14:31:38 +0100
> The newly introduced mii_ethtool_get_link_ksettings function sets
> lp_advertising to an uninitialized value when BMCR_ANENABLE is not
> set:
>
> drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings':
> drivers/net/mii.c:224:2: error: 'lp_advertising' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> As documented in include/uapi/linux/ethtool.h, the value is
> expected to be zero when we don't know it, so let's initialize
> it to that.
>
> Fixes: bc8ee596afe8 ("net: mii: add generic function to support ksetting support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Applied.