Re: [PATCH] iommu/vt-d: Fix the size calculation of pasid table

From: David Woodhouse
Date: Thu Nov 10 2016 - 06:03:01 EST


On Thu, 2016-11-10 at 11:45 +0100, Joerg Roedel wrote:
> Hi David,
>
> On Sun, Oct 30, 2016 at 06:18:22AM -0600, David Woodhouse wrote:
> > +ÂÂÂÂÂ/* Start at 2 because it's defined as 1^(1+PSS) */
>
> This probably means 2^(1+PSS), right?

Or 1 << (1+PSS). Yeah.

> > +ÂÂÂÂÂiommu->pasid_max = 2 << ecap_pss(iommu->ecap);
>
> Otherwise the patch looks good. Do you want to send it upstream yourself
> or should I pick it up?

I'll let it sit in -next for a day or two more once I've fixed the
above, then ask Linus to pull it. Thanks.

--
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature