Re: [PATCH v5 2/3] cpuid: Add a helper in scattered.c to return cpuid

From: Borislav Petkov
Date: Thu Nov 10 2016 - 06:08:49 EST


On Wed, Nov 09, 2016 at 07:05:27PM +0800, He Chen wrote:
> Some sparse CPUID leafs are gathered in a fake leaf to save size of
> x86_capability array in current code, but sometimes, kernel or other
> modules (e.g. KVM cpuid enumeration) may need actual hardware leaf

s/cpuid/CPUID/

> information.
>
> This patch adds a helper get_scattered_cpuid_leaf() to rebuild actual
> CPUID leaf, and it can be called outside by modules.
>
> Signed-off-by: He Chen <he.chen@xxxxxxxxxxxxxxx>

Modulo $Subject and typo above, the code looks ok to me:

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.