Re: [patch v5] i2c: mux: mellanox: add driver
From: Peter Rosin
Date: Thu Nov 10 2016 - 09:45:45 EST
[resend to all, got the wrong button, sorry]
On 2016-11-10 11:42, Peter Rosin wrote:
> On 2016-11-03 06:20, Vadim Pasternak wrote:
>> Hi,
>>
>> I see that this patch has not been picked-up yet for i2c-next.
>> Is it possible it was missed from some reason?
>
> Yes, apparently, really sorry about that!
>
> I'll put it in a branch and make a pull request for Wolfram (but
> that is a bit new for me, we'll see how it goes).
But now that I looked again, I noticed that the source is
dual licensed and yet your MODULE_LICENSE tag says only
"GPL v2". I.e. the same issue your i2c master driver had
that Vladimir Zapolskiy noticed.
Please fix this, and it might be a good idea to take a look
in your other drivers as well in case you have further
problems in this department...
Also, while at it, the patch doesn't apply cleanly anymore,
please rebase to something more current.
Cheers,
Peter