Re: [patch] staging: lustre: lov: crash in error handling

From: James Simmons
Date: Thu Nov 10 2016 - 14:45:10 EST



> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
>
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Yep. I just sent a patch to fix that.

> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
> size_t oinfo_ptrs_size, lsm_size;
> struct lov_stripe_md *lsm;
> struct lov_oinfo *loi;
> - unsigned int i;
> + int i;
>
> LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>
>