Re: [PATCH] firmware: fix async/manual firmware loading
From: Luis R. Rodriguez
Date: Thu Nov 10 2016 - 14:49:41 EST
On Thu, Nov 10, 2016 at 11:18 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Nov 10, 2016 at 08:07:58AM -0800, Luis R. Rodriguez wrote:
>> > It shouldn't be hard to figure out if a patch should be in stable or not...
>>
>> Well with the only caveat now that I am suggesting we consider remove
>> this logic completely as only 2 drivers were using it explicitly
>> (second argument to request_firmware_nowait() set to false), it seems
>> they had good reasons for it but ... this has been broken for ages and
>> we seem to be happy to compartamentalize the UMH further, its unclear
>> why we would want to expand and "fix" that instead of just removing
>> crap that never worked. Thoughts?
>
> Why would you want to remove stuff that works and people rely on? Don't
> be foolish, you know we can't do that...
I was not advocating removing it if it had worked, I advocated
removing it if it truly was something that never worked.
Luis