Re: [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency

[Stephen Boyd]

On 11/09, Bjorn Andersson wrote:
> On Wed 09 Nov 17:47 PST 2016, Stephen Boyd wrote:
> 
> > On 11/03, Sarangdhar Joshi wrote:
> > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > > index d79fecd..844e90d 100644
> > > --- a/drivers/firmware/qcom_scm.c
> > > +++ b/drivers/firmware/qcom_scm.c
> > > @@ -380,32 +384,40 @@ EXPORT_SYMBOL(qcom_scm_is_available);
> > >  static int qcom_scm_probe(struct platform_device *pdev)
> > >  {
> > >  	struct qcom_scm *scm;
> > > +	uint32_t clks;
> > 
> > If this was unsigned long flags;
> > 
> 
> I did look at this too and could only find a mixture of ways people have
> done this. Isn't the correct type for this intptr_t?
> 

Well unsigned long == sizeof(kernel pointer) on all Linux
platforms so it's safe to do the cast. For example, struct
timer_list stores data in unsigned long. I guess this is a
'kernelism' though? Perhaps we should update
Documentation/CodingStyle if anyone cares.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project