RE: [PATCH V2 05/10] mfd: da9061: MFD core support

[Steve Twiss]

On 11 November 2016 10:38, Lee Jones wrote:
> 
> > +static struct resource da9061_core_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_VDD_WARN, 1, "VDD_WARN", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_regulators_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_LDO_LIM, 1, "LDO_LIM", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_thermal_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_TEMP, 1, "THERMAL", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_wdt_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_WDG_WARN, 1, "WD_WARN", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_onkey_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_ONKEY, 1, "ONKEY", IORESOURCE_IRQ),
> > +};
> 
> These should al be: DEFINE_RES_IO_NAMED()

Have altered these to DEFINE_RES_IRQ_NAMED()

> > @@ -142,7 +257,7 @@ static const struct mfd_cell da9062_devs[] = {
> >  		.name		= "da9062-watchdog",
> >  		.num_resources	= ARRAY_SIZE(da9062_wdt_resources),
> >  		.resources	= da9062_wdt_resources,
> > -		.of_compatible  = "dlg,da9062-wdt",
> > +		.of_compatible  = "dlg,da9062-watchdog",
> 
> This should be a separate change.

Ok. reverted.

> > @@ -208,6 +324,7 @@ static int da9062_get_device_type(struct da9062 *chip)
> >  		dev_err(chip->dev, "Cannot read chip ID.\n");
> >  		return -EIO;
> >  	}
> > +
> 
> Sneaky!

Removed the whitespace.