Re: [PATCH V2] dmaengine: qcom_hidma: cleanup sysfs entries during remove
From: Sinan Kaya
Date: Sun Nov 13 2016 - 22:10:52 EST
On 11/13/2016 10:04 PM, Vinod Koul wrote:
> On Wed, Oct 19, 2016 at 02:42:46PM -0400, Sinan Kaya wrote:
>> The 4.8-rc8 kernel is printing duplicate file entry warnings while removing
>> the HIDMA object. This is caused by stale sysfs entries remaining from the
>> previous execution.
>>
>> _sysfs_warn_dup+0x5c/0x78
>> sysfs_add_file_mode_ns+0x13c/0x1c0
>> sysfs_create_file_ns+0x2c/0x40
>> device_create_file+0x54/0xa0
>> hidma_probe+0x7c8/0x808
>>
>> Create hidma_sysfs_init and hidma_sysfs_uninit functions and call them from
>> the probe and remove path. To do proper clean up, adding the attrs object
>> to the device data structure to keep it around until remove call is made.
>
> This doesnt apply for me, I think due to other patches applied..
>
OK. Let me rebase.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.