Re: [PATCH v3 5/9] media: venus: venc: add video encoder files

[Stanimir Varbanov]

Hi Hans,

Thanks for the comments!

On 11/11/2016 01:43 PM, Hans Verkuil wrote:
> The comments I made before about start_streaming and the use of struct venus_ctrl
> apply here as well and I won't repeat them.
> 
> On 11/07/2016 06:33 PM, Stanimir Varbanov wrote:
>> This adds encoder part of the driver plus encoder controls.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
>> ---
>>  drivers/media/platform/qcom/venus/venc.c       | 1212 ++++++++++++++++++++++++
>>  drivers/media/platform/qcom/venus/venc.h       |   32 +
>>  drivers/media/platform/qcom/venus/venc_ctrls.c |  396 ++++++++
>>  3 files changed, 1640 insertions(+)
>>  create mode 100644 drivers/media/platform/qcom/venus/venc.c
>>  create mode 100644 drivers/media/platform/qcom/venus/venc.h
>>  create mode 100644 drivers/media/platform/qcom/venus/venc_ctrls.c
>>
>> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
>> new file mode 100644
>> index 000000000000..35572eaffb9e
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/venus/venc.c
> 
> <snip>
> 
>> +static int
>> +venc_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
>> +{
>> +	struct venus_inst *inst = to_inst(file);
>> +
>> +	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
>> +		return -EINVAL;
>> +
>> +	switch (s->target) {
>> +	case V4L2_SEL_TGT_CROP:
>> +		if (s->r.width != inst->out_width ||
>> +		    s->r.height != inst->out_height ||
>> +		    s->r.top != 0 || s->r.left != 0)
>> +			return -EINVAL;
>> +		break;
>> +	default:
>> +		return -EINVAL;
>> +	}
>> +
>> +	return 0;
>> +}
> 
> Why implement s_selection if I can't change the selection?

without s_selection the v4l2-compliance test starts failing with:

fail: v4l2-test-formats.cpp(1319): doioctl(node, VIDIOC_S_SELECTION,
&sel_crop) != EINVAL

fail: v4l2-test-formats.cpp(1407): testBasicCrop(node,
V4L2_BUF_TYPE_VIDEO_OUTPUT)

> 
>> +
>> +static int
>> +venc_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *b)
>> +{
>> +	struct vb2_queue *queue = to_vb2q(file, b->type);
>> +
>> +	if (!queue)
>> +		return -EINVAL;
>> +
>> +	return vb2_reqbufs(queue, b);
>> +}
> 
> Use the m2m helpers if at all possible.

I've answered already to that in 4/9.

-- 
regards,
Stan