Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

[Jani Nikula]

On Sat, 12 Nov 2016, Fabian Frederick <fabf@xxxxxxxxx> wrote:
> -#if defined(CONFIG_HWMON) || (defined(MODULE) && defined(CONFIG_HWMON_MODULE))
> +#if IS_REACHABLE(CONFIG_HWMON)

The changes seem to make sense per se, but I'd be interested in hearing
the rationale for not expressing this dependency in terms of Kconfig to
begin with. With this, it's hidden in code, and the hwmon stuff gets
used if the conditions for "nouveau depends on hwmon" are met, by
chance, but it's not enforced.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center