Re: [PATCH v4] i2c: designware: Implement support for SMBus block read and write

[Andy Shevchenko]

On Mon, 2016-11-14 at 11:59 +0100, Alexander Stein wrote:
> On Thursday 10 November 2016 09:56:33, tnhuynh@xxxxxxx wrote:

> > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > @@ -75,6 +75,7 @@ struct dw_pci_controller {
> > Â					I2C_FUNC_SMBUS_BYTE |	
> > 	\
> > Â					I2C_FUNC_SMBUS_BYTE_DATA |	
> > \
> > Â					I2C_FUNC_SMBUS_WORD_DATA |	
> > \
> > +					I2C_FUNC_SMBUS_BLOCK_DATA |
> > 	\
> > Â					I2C_FUNC_SMBUS_I2C_BLOCK)
> > 
> > Â/* Merrifield HCNT/LCNT/SDA hold time */
> > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> > b/drivers/i2c/busses/i2c-designware-platdrv.c index 0b42a12..886fb62
> > 100644
> > --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> > @@ -220,6 +220,7 @@ static int dw_i2c_plat_probe(struct
> > platform_device
> > *pdev) I2C_FUNC_SMBUS_BYTE |
> > Â		I2C_FUNC_SMBUS_BYTE_DATA |
> > Â		I2C_FUNC_SMBUS_WORD_DATA |
> > +		I2C_FUNC_SMBUS_BLOCK_DATA |
> > Â		I2C_FUNC_SMBUS_I2C_BLOCK;
> > 
> > Â	dev->master_cfg = DW_IC_CON_MASTER |
> > DW_IC_CON_SLAVE_DISABLE |
> 
> Shouldn't those functionality bits moved to a common place, like i2c-
> designware-core.h?

It would. But it's a separate story. So, if you are willing to do this,
go ahead and send a patch.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy