Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory
From: Michael Ellerman
Date: Mon Nov 14 2016 - 06:59:52 EST
Reza Arbab <arbab@xxxxxxxxxxxxxxxxxx> writes:
> When movable nodes are enabled, any node containing only hotpluggable
> memory is made movable at boot time.
>
> On x86, hotpluggable memory is discovered by parsing the ACPI SRAT,
> making corresponding calls to memblock_mark_hotplug().
>
> If we introduce a dt property to describe memory as hotpluggable,
> configs supporting early fdt may then also do this marking and use
> movable nodes.
So I'm not opposed to this, but it is a little vague.
What does the "hotpluggable" property really mean?
Is it just a hint to the operating system? (which may or may not be
Linux).
Or is it a direction, "this memory must be able to be hotunplugged"?
I think you're intending the former, ie. a hint, which is probably OK.
But it needs to be documented clearly.
cheers