Re: [PATCH 31/35] staging: lustre: obdclass: add export for lprocfs_stats_alloc_one()

From: Greg Kroah-Hartman
Date: Mon Nov 14 2016 - 09:59:49 EST


On Thu, Nov 10, 2016 at 12:31:01PM -0500, James Simmons wrote:
> From: Chennaiah Palla <chennaiah.palla@xxxxxxxxxxx>
>
> When compiling the kernel without optimization, when using GCOV,
> the lprocfs_stats_alloc_one() symbol is not properly exported to
> other modules and causes the ptlrpc module to fail loading with
> an unknown symbol. Added EXPORT_SYMBOL(lprocfs_stats_alloc_one)
> so that this works properly.

No, let's fix this properly. Please get rid of lprocfs_stats_lock(), or
if you _really_ need it, move it to a .c file. Having it in a .h file
is just a mess, as this proves.

thanks,

greg k-h