Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399

[Caesar Wang]

On 2016å11æ12æ 12:22, Shawn Lin wrote:
> On 2016/11/9 21:21, Caesar Wang wrote:
> > From: Ziyuan Xu <xzy.xu@xxxxxxxxxxxxxx>
> >
> > Control power domain for eMMC via genpd to reduce power consumption.
> >
> > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> > Signed-off-by: Ziyuan Xu <xzy.xu@xxxxxxxxxxxxxx>
> > Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>
>
> It was verified on my rk3399 evb with kernel4.4, so
> free feel to add my tag,
>
> Tested-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

Thanks the tests.

> BTW, it seems my reply is bounced form Yakir's address, so please
> remove him from CC list if he changed his mail address.

Right, Yakir's (ykk@xxxxxxxxxxxxxx) address had left this world.;-)
But the patman tool is auto sending with the Cc people.

-
Caesar
> > ---
> >
> > Changes in v2:
> > - Reviewed-on: https://chromium-review.googlesource.com/376558
> > - Verified on ChromeOS kernel4.4
> >
> > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
> > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index cbb7f8b..b401176 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -269,6 +269,7 @@
> > #clock-cells = <0>;
> > phys = <&emmc_phy>;
> > phy-names = "phy_arasan";
> > + power-domains = <&power RK3399_PD_EMMC>;
> > status = "disabled";
> > };
> >
> > @@ -690,6 +691,11 @@
> > status = "disabled";
> > };
> >
> > + qos_emmc: qos@ffa58000 {
> > + compatible = "syscon";
> > + reg = <0x0 0xffa58000 0x0 0x20>;
> > + };
> > +
> > qos_gmac: qos@ffa5c000 {
> > compatible = "syscon";
> > reg = <0x0 0xffa5c000 0x0 0x20>;
> > @@ -823,6 +829,11 @@
> > };
> >
> > /* These power domains are grouped by VD_LOGIC */
> > + pd_emmc@RK3399_PD_EMMC {
> > + reg = <RK3399_PD_EMMC>;
> > + clocks = <&cru ACLK_EMMC>;
> > + pm_qos = <&qos_emmc>;
> > + };
> > pd_gmac@RK3399_PD_GMAC {
> > reg = <RK3399_PD_GMAC>;
> > clocks = <&cru ACLK_GMAC>;


--
caesar wang | software engineer | wxt@xxxxxxxxxxxxx