Re: [PATCH v2 1/2] mfd: pm8xxx: add support to pm8821

From: Srinivas Kandagatla
Date: Mon Nov 14 2016 - 14:33:10 EST




On 14/11/16 18:40, Stephen Boyd wrote:
On 11/14/2016 09:52 AM, Srinivas Kandagatla wrote:
diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
index 7f9620e..dc347d3 100644
--- a/drivers/mfd/qcom-pm8xxx.c
+++ b/drivers/mfd/qcom-pm8xxx.c
+
+static void pm8821_irq_handler(struct irq_desc *desc)
+{
+ struct pm_irq_chip *chip = irq_desc_get_handler_data(desc);
+ struct irq_chip *irq_chip = irq_desc_get_chip(desc);
+ unsigned int master;
+ int ret;
+
+ chained_irq_enter(irq_chip, desc);
+ ret = regmap_read(chip->regmap,
+ PM8821_SSBI_REG_ADDR_IRQ_MASTER0, &master);
+ if (ret) {
+ pr_err("Failed to re:Qad master 0 ret=%d\n", ret);

Hm? vi?
yes.. That was good catch!! will fix it in next version...