Re: [PATCH 05/11] mtd: nand: denali: remove "Spectra:" prefix from printk strings
From: Masahiro Yamada
Date: Mon Nov 14 2016 - 21:32:38 EST
2016-11-13 6:35 GMT+09:00 Marek Vasut <marek.vasut@xxxxxxxxx>:
> On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
>> As far as I understood from the Kconfig menu deleted by commit
>> be7f39c5ecf5 ("Staging: delete spectra driver"), the "Spectra" is
>> specific to Intel Moorestown Platform.
>>
>> The Denali NAND controller IP is used for various SoCs such as
>> Altera SOCFPGA, Socionext UniPhier, etc. The platform specific
>> strings are not preferred in this driver.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>
> Reviewed-by: Marek Vasut <marek.vasut@xxxxxxxxx>
>
>> ---
>>
>> As an ARM-SoC developer, I only need denali.c and denali_dt.c.
>>
>> I see some "Spectra:" in drivers/mtd/nand/denali_pci.c as well.
>> I was not quite sure if they are needed or not.
>> If desired, I can update this patch to remove them too.
>
> Is anyone even using Denali on Intel now ?
I assume this question is address to Intel guys, not me.
May I drop the "Spectra:" from printk strings entirely?
--
Best Regards
Masahiro Yamada