Re: LEDs that change brightness "itself" -- that's a trigger. Re: PM regression with LED changes in next-20161109

[Hans de Goede]

Hi,

On 15-11-16 12:11, Pavel Machek wrote:
> On Tue 2016-11-15 11:58:06, Jacek Anaszewski wrote:
> > On 11/15/2016 11:31 AM, Pavel Machek wrote:
> > > Hi!
> > >
> > > > > Hmm, v4 still calls led_notify_brightness_change(led_cdev)
> > > > >from both __led_set_brightness() and __led_set_brightness_blocking().
> > > >
> > > > Ugh, I see I accidentally send a v4 twice, instead of
> > > > calling the version which dropped those called v5 as
> > > > I should have, sorry.
> > > >
> > > > The v4 which I would like to see merged, the one with
> > > > those calls dropped, is here:
> > > >
> > > > https://patchwork.kernel.org/patch/9423093/
> > >
> > > Please, lets fix this properly.
> > >
> > > The LED you are talking about _has_ a trigger, implemented in
> > > hardware. That trigger can change LED brightness behind kernel's (and
> > > userspace's) back. Don't pretend the trigger does not exist, it does.
> > >
> > > And when you do that, you'll have nice place to report changes to
> > > userspace -- trigger can now export that information, and offer poll()
> > > interface.
> >
> > Well, that sounds interesting. It is logically justifiable.
>
> Thanks.
>
> > I initially proposed exactly this solution, with recently
> > added userspace LED being a trigger listener. It seems a bit
> > awkward though. How would you listen to the trigger events?
>
> Trigger exposes a file in sysfs, with poll() working on that file

Hmm, a new file would give the advantage of making it easy for
userspace to see if the trigger is poll-able, this is likely
better then my own proposal I just send.

> (and
> probably read exposing the current brightness).

If we do this, can we please make it mirror brightness, iow
also make it writable, that will make it easier for userspace
to deal with it. We can simply re-use the existing show / store
methods for brightness for this.

I suggest we call it:

trigger_brightness

And only register it when a poll-able trigger is present.


> Key difference is that only triggers where this makes sense (keyboard
> backlight) expose it and carry the overhead. CPU trigger would
> definitely not do this.

Ack only having some triggers pollable is important.

Regards,

Hans