Re: [PATCH] HID: udraw-ps3: accel_limits is local to the driver

[Bastien Nocera]

On Tue, 2016-11-15 at 14:26 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@xxxxxxx>
> 
> And as such should be marked static to avoid global namespace
> pollution.
> 
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

Yes, thanks.

Reviewed-by: Bastien Nocera <hadess@xxxxxxxxxx>

> ---
> 
> I've just applied this on top of hid.git#for-4.10/udraw-ps3
> 
> Âdrivers/hid/hid-udraw-ps3.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-udraw-ps3.c b/drivers/hid/hid-udraw-
> ps3.c
> index 1f68b0b..88ea390 100644
> --- a/drivers/hid/hid-udraw-ps3.c
> +++ b/drivers/hid/hid-udraw-ps3.c
> @@ -54,7 +54,7 @@ enum {
> Â * Accelerometer min/max values
> Â * in order, X, Y and Z
> Â */
> -struct {
> +static struct {
> ÂÂÂÂÂÂÂÂint min;
> ÂÂÂÂÂÂÂÂint max;
> Â} accel_limits[] = {
> 
> --Â
> Jiri Kosina
> SUSE Labs
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> input" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html