Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided

From: Michal Simek
Date: Tue Nov 15 2016 - 08:59:21 EST


On 14.11.2016 13:13, Zubair Lutfullah Kakakhel wrote:
> The powerpc dts file does not have the xlnx,kind-of-intr property.
> Instead of erroring out, give a warning instead. And attempt to
> continue to probe the interrupt controller while assuming
> kind-of-intr is 0x0 as a fall back.
>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
>
> ---
> V6 -> V7
> Rebase to v4.9-rc5
>
> V5 -> V6
> Rebase to v4.9-rc3
>
> V5 new patch
> ---
> drivers/irqchip/irq-xilinx-intc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c
> index 971c141..d330917 100644
> --- a/drivers/irqchip/irq-xilinx-intc.c
> +++ b/drivers/irqchip/irq-xilinx-intc.c
> @@ -179,8 +179,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>
> ret = of_property_read_u32(intc, "xlnx,kind-of-intr", &irqc->intr_mask);
> if (ret < 0) {
> - pr_err("irq-xilinx: unable to read xlnx,kind-of-intr\n");
> - goto err_alloc;
> + pr_warn("irq-xilinx: unable to read xlnx,kind-of-intr\n");
> + irqc->intr_mask = 0;
> }
>
> if (irqc->intr_mask >> nr_irq)
>


Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal