Re: [PATCH 2/2] ARM: zynq: Fix W=1 dtc 1.4 warnings

[Julia Cartwright]

On Tue, Nov 15, 2016 at 03:07:27PM +0100, Michal Simek wrote:
> The patch removes these warnings reported by dtc 1.4:
> Warning (unit_address_vs_reg): Node /pmu has a reg or ranges property,
> but no unit name
> Warning (unit_address_vs_reg): Node /fixedregulator@0 has a unit name,
> but no reg property
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> property, but no unit name
> 
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>

Reviewed-by: Julia Cartwright <julia@xxxxxx>
>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi      | 4 ++--
>  arch/arm/boot/dts/zynq-parallella.dts | 2 +-
>  arch/arm/boot/dts/zynq-zc702.dts      | 2 +-
>  arch/arm/boot/dts/zynq-zc706.dts      | 2 +-
>  arch/arm/boot/dts/zynq-zed.dts        | 2 +-
>  arch/arm/boot/dts/zynq-zybo.dts       | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index f47a6c1cc752..402b5bbe3b5b 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -42,14 +42,14 @@
>  		};
>  	};
>  
> -	pmu {
> +	pmu@f8891000 {
>  		compatible = "arm,cortex-a9-pmu";
>  		interrupts = <0 5 4>, <0 6 4>;
>  		interrupt-parent = <&intc>;
>  		reg = < 0xf8891000 0x1000 0xf8893000 0x1000 >;

Style nit: we should drop the space before/after '<' and '>'; and,
perhaps separate the entries to be a bit more readable:

   reg = <0xf8891000 0x1000>,
         <0xf8893000 0x1000>;

Thanks,

   Julia