Re: [PATCH] printk, locking/atomics, kref: Introduce new %pAr and %pAk format string options for atomic_t and 'struct kref'
From: Linus Torvalds
Date: Tue Nov 15 2016 - 11:42:48 EST
On Tue, Nov 15, 2016 at 12:37 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> +atomic variables such atomic_t or struct kref:
> +
> + %pAr atomic_t count
> + %pAk struct kref count
Not a huge fan. That "r" makes sense to you ("raw" atomic), but it
makes no sense to a user. An atomic isn't "raw" to anybody else. It's
just an atomic.
Also, we have 'atomic64_t", which this doesn't cover at all.
I'd suggest just %pA, %pA64, %pAkref or something. Which leaves us the
choice to add more atomic versions later without having to make up
random one-letter things that make no sense.
Linus