Re: [PATCH 03/15] net: bcm63xx_enet: Utilize phy_ethtool_nway_reset
From: Florian Fainelli
Date: Tue Nov 15 2016 - 15:15:49 EST
On 11/15/2016 11:59 AM, Heinrich Schuchardt wrote:
> On 11/15/2016 07:06 PM, Florian Fainelli wrote:
>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> Each patch of your patch series should have a commit message.
It's pretty obvious what this does, really.
>
> You can add the missing commit messages with
> git rebase -i HEAD~15
> choosing reword.
>
> Please, add a cover letter message describing the patch series using
>
> git format-patch -ns --cover-letter HEAD~15..HEAD
>
> and provide a summary in the 0/15 message.
I did:
https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/maillist.html
and that is also apparent from:
In-Reply-To: <20161115180644.3941-1-f.fainelli@xxxxxxxxx>
References: <20161115180644.3941-1-f.fainelli@xxxxxxxxx>
And what I also did is to intentionally make sure that for each patch,
there would not be 50+ people CC'd, but just the relevant people for
each driver, which is exactly how cc-cmd=scripts/get_maintainer.pl work,
making my life simpler honestly.
It's not nearly my first patch submission, but I admit I have been semi
intentionally lazy with this patch set considering the number of patches.
Anyway, enough time wasted on this.
--
Florian