Re: [PATCH] cpufreq: intel_pstate: Generic governors support
From: Rafael J. Wysocki
Date: Tue Nov 15 2016 - 17:37:21 EST
On Tue, Nov 15, 2016 at 6:05 PM, Doug Smythies <dsmythies@xxxxxxxxx> wrote:
> On 2016.11.13 16:08 Rafael J. Wysocki wrote:
>
>> Rebased on top of my linux-next branch, which in turn is based on 4.9-rc5 now.
>>
>> I'm running this on my IVB laptop w/ the schedutil governor, no problems so
>> far (fingers crossed).
>
> I did the exact same tests as I did with your earlier RFT/RFC version
> of this patch, with the exact same results. I still think something is wrong.
Thanks for the report!
> Reference:
> http://marc.info/?l=linux-kernel&m=147803469901959&w=2
As far as I can test it, both ondemand and schedutil governors work as
expected with it (I haven't tested conservative directly, but it is
similar enough to ondemand).
What happens with the powersave and performance governors is that
->target() is only called once by each of them (during initialization)
and each time the min/max limits change. That's why you won't see new
requests coming when using any of those two.
Thanks,
Rafael