Re: [PATCH 1/2] ovl: use kernel facility for copying attributes

From: Miklos Szeredi
Date: Wed Nov 16 2016 - 04:23:20 EST


On Tue, Nov 15, 2016 at 5:54 PM, Quorum Laval <quorum.laval@xxxxxxxxx> wrote:
> Replace ovl_copyattr() by fsstack_copy_attr_all() and drop the definition of
> the former.

This isn't trivially correct, fsstack_copy_attr_all() copies more than
ovl_copyattr(). We need a better explanation for why it is correct
to copy all the other attributes as well.

Thanks,
Miklos