Re: [PATCH] checkpatch: don't check c99 types like uint8_t under tools

From: Joe Perches
Date: Wed Nov 16 2016 - 09:34:48 EST


On Wed, 2016-11-16 at 10:52 +0200, Tomas Winkler wrote:
> Tools contains user space code so uintX_t types are just fine.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1c4348..42c3221be6eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5548,8 +5548,9 @@ sub process {
> "Using weak declarations can have unintended link defects\n" . $herecurr);
> }
>
> -# check for c99 types like uint8_t used outside of uapi/
> +# check for c99 types like uint8_t used outside of uapi/ and tools/
> if ($realfile !~ m@\binclude/uapi/@ &&
> + $realfile !~ m@\btools/@ &&
> $line =~ /\b($Declare)\s*$Ident\s*[=;,\[]/) {
> my $type = $1;
> if ($type =~ /\b($typeC99Typedefs)\b/) {

Makes sense, thanks.

Acked-by: Joe Perches <joe@xxxxxxxxxxx>