Re: [PATCH 07/34] [media] DaVinci-VPBE: Delete an unnecessary variable initialisation in vpbe_initialize()

From: Mauro Carvalho Chehab
Date: Wed Nov 16 2016 - 09:35:49 EST


Em Wed, 12 Oct 2016 16:42:31 +0200
SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> escreveu:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 12 Oct 2016 09:45:39 +0200
>
> The local variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/davinci/vpbe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
> index afa8ff7..9fdd8c0 100644
> --- a/drivers/media/platform/davinci/vpbe.c
> +++ b/drivers/media/platform/davinci/vpbe.c
> @@ -597,7 +597,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
> struct osd_state *osd_device;
> struct i2c_adapter *i2c_adap;
> int num_encoders;
> - int ret = 0;
> + int ret;
> int err;

Please fold this change to the patch where you'll be addressing the
issues with "err" var, as per my previous email.




Thanks,
Mauro