Re: [PATCH] scr24x_cs: include linux/io.h

[Lubomir Rintel]

On Wed, 2016-11-16 at 16:23 +0100, Arnd Bergmann wrote:
> The newly added scr24x_cs driver doesn't build in some
> configurations:
> 
> drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready':
> drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of
> function 'ioread8' [-Werror=implicit-function-declaration]
> 
> Adding in explicit include for the right header makes it work.
> 
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Âdrivers/char/pcmcia/scr24x_cs.c | 1 +
> Â1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce1a3be..a1de354a89a7 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -27,6 +27,7 @@
> Â#include <linux/cdev.h>
> Â#include <linux/slab.h>
> Â#include <linux/fs.h>
> +#include <linux/io.h>
> Â#include <linux/uaccess.h>
> Â
> Â#include <pcmcia/cistpl.h>

Acked-by: Lubomir Rintel <lkundrak@xxxxx>

Thanks