Re: linux-next: build warning after merge of the phy-next tree

[Kishon Vijay Abraham I]

Hi,

On Wednesday 16 November 2016 06:58 PM, wlf wrote:
> Hi Stephenï
> 
> å 2016å11æ16æ 11:00, Stephen Rothwell åé:
>> Hi Kishon,
>>
>> After merging the phy-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
>> drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
>>      if (tmout) {
>>         ^
>>
>> Introduced by commit
>>
>>    0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")

Thank you for reporting this issue.

> The variable "tmout" is initialized in the prior  code "case
> USB_CHG_STATE_WAIT_FOR_DCD",
> and this case will be executed before "if (tmout)", so I think it's a
> mis-warning for some
> special compiler.
> 
> Could you provide me some suggestion about this warning? Should I upload a new
> patch to
> fix this compiler mis-warning or just ignore it ï :-)

Arnd has already sent a fix it. I've picked that one.

Thanks
Kishon