Re: [PATCH] scsi: dmx3191d: use module_pci_driver

[Finn Thain]

On Wed, 16 Nov 2016, Geliang Tang wrote:

> Use module_pci_driver() helper to simplify the code.
> 
> Signed-off-by: Geliang Tang <geliangtang@xxxxxxxxx>

Acked-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

> ---
>  drivers/scsi/dmx3191d.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c
> index 3aa4657..6af3394 100644
> --- a/drivers/scsi/dmx3191d.c
> +++ b/drivers/scsi/dmx3191d.c
> @@ -153,18 +153,7 @@ static struct pci_driver dmx3191d_pci_driver = {
>  	.remove		= dmx3191d_remove_one,
>  };
>  
> -static int __init dmx3191d_init(void)
> -{
> -	return pci_register_driver(&dmx3191d_pci_driver);
> -}
> -
> -static void __exit dmx3191d_exit(void)
> -{
> -	pci_unregister_driver(&dmx3191d_pci_driver);
> -}
> -
> -module_init(dmx3191d_init);
> -module_exit(dmx3191d_exit);
> +module_pci_driver(dmx3191d_pci_driver);
>  
>  MODULE_AUTHOR("Massimo Piccioni <dafastidio@xxxxxxxxx>");
>  MODULE_DESCRIPTION("Domex DMX3191D SCSI driver");
>