Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy performance hint using HWP

[Viresh Kumar]

Hi Srinivas,

I don't think other platforms need it for now and so it is fine to
add these to the driver itself.

On 15-11-16, 14:59, Srinivas Pandruvada wrote:
> +static ssize_t show_energy_performance_available_preferences(

Maybe a personal preference, but I would have broken the line after
ssize_t instead of where you have done it.

> +				struct cpufreq_policy *policy, char *buf)
> +{
> +static struct freq_attr *hwp_cpufreq_attrs[] = {
> +	&energy_performance_preference,
> +	&energy_performance_available_preferences,
> +	NULL,
> +};

What about adding these to intel_pstate_attr_group instead ?

-- 
viresh