Re: [PATCH] edac: mpc85xx: implement "remove" for mpc85xx_pci_err_driver

[Borislav Petkov]

On Thu, Nov 17, 2016 at 10:56:20AM +0800, yanjiang.jin@xxxxxxxxxxxxx wrote:
> From: Yanjiang Jin <yanjiang.jin@xxxxxxxxxxxxx>
> 
> Tested on a T4240QDS board.
> 
> If we execute the below steps without this patch:
> 
> 1. modprobe mpc85xx_edac [The first insmod, everything is well.]
> 2. modprobe -r mpc85xx_edac
> 3. modprobe mpc85xx_edac [insmod again, error happens.]
> 
> We would get the error messages as below:
> 
> BUG: recent printk recursion!
> Oops: Kernel access of bad area, sig: 11 [#48]
> Modules linked in: mpc85xx_edac edac_core softdog [last unloaded: mpc85xx_edac]
> CPU: 5 PID: 14773 Comm: modprobe Tainted: G D C 4.8.3-rt2
> 
>  .vsnprintf
>  .vscnprintf
>  .vprintk_emit
>  .printk
>  .edac_pci_add_device
>  .mpc85xx_pci_err_probe
>  .platform_drv_probe
>  .driver_probe_device
>  .__driver_attach
>  .bus_for_each_dev
>  .driver_attach
>  .bus_add_driver
>  .driver_register
>  .__platform_register_drivers
>  .mpc85xx_mc_init
>  .do_one_initcall
>  .do_init_module
>  .load_module
>  .SyS_finit_module
>  system_call
> 
> Signed-off-by: Yanjiang Jin <yanjiang.jin@xxxxxxxxxxxxx>
> ---
>  drivers/edac/mpc85xx_edac.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.