Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev

[Alex Williamson]

On Thu, 17 Nov 2016 21:30:26 +0530
Kirti Wankhede <kwankhede@xxxxxxxxxx> wrote:

> On 11/17/2016 8:57 PM, Alex Williamson wrote:
> > On Thu, 17 Nov 2016 20:35:38 +0800
> > Jike Song <jike.song@xxxxxxxxx> wrote:
> >   
> >> On 11/17/2016 04:46 AM, Kirti Wankhede wrote:  
> >>> Add a notifier calback to parent's ops structure of mdev device so that per
> >>> device notifer for vfio module is registered through vfio_mdev module.
> >>>
> >>> Signed-off-by: Kirti Wankhede <kwankhede@xxxxxxxxxx>
> >>> Signed-off-by: Neo Jia <cjia@xxxxxxxxxx>
> >>> Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
> >>> ---
> >>>  drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++-
> >>>  include/linux/mdev.h          |  9 +++++++++
> >>>  2 files changed, 42 insertions(+), 1 deletion(-)
> >>>  
> >>
> >> Hi Alex, Kirti,
> >>
> >> Since everyone agreed we should let the vendor driver call vfio_register_notifier
> >> directly, can you drop this patch from merging? So that I don't need to send a
> >> reverse patch.  
> > 
> > This seems like a reasonable request to me, this patch drops cleanly
> > from the series.  Any objection Kirti?  It seems like it removes a
> > little bit of pre-release churn from the API.  Thanks,
> >   
> 
> This is independent patch, I don't have any concern to drop this patch.
> 
> Small nit: Since Documentation patch is later in series, its mentioned
> in the doc. One line need to be removed from vfio-mediated-device.txt.
> 
> --- a/Documentation/vfio-mediated-device.txt
> +++ b/Documentation/vfio-mediated-device.txt
> @@ -150,7 +150,6 @@ The callbacks in the parent_ops structure are as
> follows:
>  * read : read emulation callback
>  * write: write emulation callback
>  * mmap: mmap emulation callback
> -* notifier: notifier callback

Good catch, I'll remove this line.  Thanks,

Alex