Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev

From: Alex Williamson
Date: Thu Nov 17 2016 - 12:54:25 EST


On Thu, 17 Nov 2016 20:35:38 +0800
Jike Song <jike.song@xxxxxxxxx> wrote:

> On 11/17/2016 04:46 AM, Kirti Wankhede wrote:
> > Add a notifier calback to parent's ops structure of mdev device so that per
> > device notifer for vfio module is registered through vfio_mdev module.
> >
> > Signed-off-by: Kirti Wankhede <kwankhede@xxxxxxxxxx>
> > Signed-off-by: Neo Jia <cjia@xxxxxxxxxx>
> > Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
> > ---
> > drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++-
> > include/linux/mdev.h | 9 +++++++++
> > 2 files changed, 42 insertions(+), 1 deletion(-)
> >
>
> Hi Alex, Kirti,
>
> Since everyone agreed we should let the vendor driver call vfio_register_notifier
> directly, can you drop this patch from merging? So that I don't need to send a
> reverse patch.

This seems like a reasonable request to me, this patch drops cleanly
from the series. Any objection Kirti? It seems like it removes a
little bit of pre-release churn from the API. Thanks,

Alex