Re: [PATCH v12 4/7] x86/syscalls/32: Wire up arch_prctl on x86-32

From: Ingo Molnar
Date: Fri Nov 18 2016 - 02:30:25 EST



* Kyle Huey <me@xxxxxxxxxxxx> wrote:

> --- a/include/linux/compat.h
> +++ b/include/linux/compat.h
> @@ -716,16 +716,18 @@ int __compat_save_altstack(compat_stack_t __user *, unsigned long);
> } while (0);
>
> asmlinkage long compat_sys_sched_rr_get_interval(compat_pid_t pid,
> struct compat_timespec __user *interval);
>
> asmlinkage long compat_sys_fanotify_mark(int, unsigned int, __u32, __u32,
> int, const char __user *);
>
> +asmlinkage long compat_sys_arch_prctl(int, unsigned long);

Please always use prototypes with proper argument names spelled out, i.e.:

+asmlinkage long compat_sys_arch_prctl(int option, unsigned long arg2);

Thanks,

Ingo