Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion

From: Binoy Jayan
Date: Fri Nov 18 2016 - 04:10:24 EST


Hi Arnd,

On 18 November 2016 at 14:28, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday, November 18, 2016 12:27:32 PM CET Binoy Jayan wrote:
>> Hi Sagi,

> I think you are right. This is behavior is actuallly documented in
> Documentation/scheduler/completion.txt:

Thanking for having a look.

> However, this is fairly unusual behavior and I wasn't immediately aware
> of it either when I read Sagi's reply. While your patch looks correct,
> it's probably a good idea to point out the counting behavior of this
> completion as explicitly as possible, in the changelog text of the patch
> as well as in a code comment and perhaps in the naming of the completion.

Will mention this and resend the patch series.

Thanks,
Binoy