Re: [PATCH] ARM: dts: qcom: Add apq8064 CoreSight components

[Georgi Djakov]

On 11/18/2016 12:16 AM, Stephen Boyd wrote:
> On 11/17/2016 07:36 AM, Georgi Djakov wrote:
> > From: "Ivan T. Ivanov" <ivan.ivanov@xxxxxxxxxx>
> >
> > Add initial set of CoreSight components found on Qualcomm's
> > 8064 chipset.
> >
> > Signed-off-by: Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx>
> > Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/qcom-apq8064-coresight.dtsi | 196 ++++++++++++++++++++++++++
>
> Why not put this inside the soc file? This would be the first time we
> add a new file for something that's inside the SoC node that probably
> won't change thereafter. At least for pins I slightly agree with having
> a different file, we're adding more and more things there so it's nice
> to have a consolidated place of all possible configurations to choose
> from. But here it's mostly a static device description so what's the gain?

Ok, after thinking more about this and looking at other soc dtsi files i 
agree with you. Will update!

Thanks!
Georgi