Re: [PATCH v3 0/2] DW DMAC: update device tree

[Andy Shevchenko]

On Fri, 2016-11-18 at 22:12 +0300, Eugeniy Paltsev wrote:
> It wasn't possible to enable some features like
> memory-to-memory transfers or multi block transfers via DT.
> It is fixed by these patches.

First of all, please, give time to reviewers to comment the patches.
Usually it should be at least 24h (for the series that has been sent
first time 1 week approximately).

> 
> Changes for v3:
> Â* Update existing platform data.
> ÂÂÂWe don't need to update existing DTS because default logicÂ
> ÂÂÂwasn't change: we don't set "is_nollp" if we readÂ
> ÂÂÂconfiguration from DT before. And we don't set it now if
> ÂÂÂ"multi-block" property doesn't exist in DTS.

See my comments in the patches.
And do not send the updated version earlier than Monday, please.

> 
> Changes for v2:
> Â* I thought about is_memcpy DT property: all known devices, whichÂ
> ÂÂÂuse DT for configuration, support memory-to-memory transfers.Â
> ÂÂÂSo we don't need to read it from DT. So enable it by default,Â
> ÂÂÂif we read configuration from DT.
> 
> Â* Use "multi-block" instead of "hw-llp" name to be more clear.
> 
> Â* Move adding DT property and adding documentation for this
> ÂÂÂproperty to one patch.
> 
> Eugeniy Paltsev (2):
> Â DW DMAC: enable memory-to-memory transfers support
> Â DW DMAC: add multi-block property to device tree
> 
> ÂDocumentation/devicetree/bindings/dma/snps-dma.txt |ÂÂ2 ++
> Âdrivers/dma/dw/core.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> Âdrivers/dma/dw/platform.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 11 +++++++++++
> Âdrivers/tty/serial/8250/8250_lpss.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> Âinclude/linux/platform_data/dma-dw.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ4 ++--
> Â5 files changed, 17 insertions(+), 4 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy