Re: [PATCH] infiniband: remove WARN that is not kernel bug

[Valdis . Kletnieks]

On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said:
> WARNINGs mean kernel bugs.
> The one in ucma_write() points to user programming error
> or a malicious attempt. This is not a kernel bug, remove it.

> -	if (WARN_ON_ONCE(!ib_safe_file_access(filp)))
> +	if (!ib_safe_file_access(filp))
>  		return -EACCES;

In that case, wouldn't this be better?

	if (!ib_safe_file_access(filp)) {
		printk_once("Process %d (%s) tried to do something hinky", pid, comm);
		return _EACCESS;
	}

so the sysadmin becomes aware of the malicious attempt?

Attachment: pgpSgop3isXyE.pgp
Description: PGP signature