Re: [RFC][PATCH 7/7] kref: Implement using refcount_t

From: Peter Zijlstra
Date: Sat Nov 19 2016 - 06:45:25 EST


On Sat, Nov 19, 2016 at 07:14:08AM +0000, Reshetova, Elena wrote:
> > Well, if you get to tools (cocci script or whatever) to reliably work
> > fork atomic_t, then converting the few atomic_long_t's later should be
> > trivial.
>
> I am using coccinelle to find all occurrences, but I do the changes
> only in semi-automated fashion.

If you can get the detection solid, that's good enough.

> Each change needs a proper manual review anyway and often one variable
> usage is spread between different headers/source files, so I prefer
> not to go to full automation and then not being sure what I have done.

Sure, every patch needs review, regardless of how it came to be.