Re: [PATCH 00/11] mtd: nand: denali: first round of cleanups of Denali NAND driver

[Masahiro Yamada]

Hi Boris,


2016-11-19 17:30 GMT+09:00 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>:
> Hi Masahiro,
>
> On Wed,  9 Nov 2016 13:35:19 +0900
> Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
>> I am tackling on this driver to use it for my SoCs.
>> The difficulty is a bunch of platform specific stuff
>> (more specifically, Intel MRST specific) is hard-coded in this driver.
>>
>> I need lots of rework to utilize the driver for generic cases,
>> but at the same time, I found the driver code is really dirty,
>> lots of unused code, odd comments, etc.
>>
>> The first thing I needed to do was to clean up the code.
>> My work is still under the way, but I decided to drop this series
>> for now.  I hope this series is easy to review, so I guess
>> splitting into a small chunks is better than a one-shot patch bomb.
>
> Well, all I've seen coming from you so far are minor cleanups and
> cosmetic changes (including one introducing a regression).
> I'll apply this series, but please, next time, try to send the whole
> series, so that we can see the big picture, and not just random
> cleanups.
>
> Thanks,
>
> Boris

Right, this series alone is not useful at all.

I've been mostly stuck in some local works this week,
but hopefully I will find some time to complete the series next week.

If you want to see the big picture,
you can postpone this series until then.



-- 
Best Regards
Masahiro Yamada