Re: [v3,3/3] hwmon: (mcp3021) replace S_IRUGO with 0444

From: Guenter Roeck
Date: Sat Nov 19 2016 - 11:30:03 EST


On Wed, Nov 09, 2016 at 06:16:14PM +0100, Clemens Gruber wrote:
> Replace S_IRUGO with the better readable 0444.
> This fixes a checkpatch warning.
>
> Signed-off-by: Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>

Applied to -next.

Guenter

> ---
> drivers/hwmon/mcp3021.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mcp3021.c b/drivers/hwmon/mcp3021.c
> index 81f4b7f..3a007ab 100644
> --- a/drivers/hwmon/mcp3021.c
> +++ b/drivers/hwmon/mcp3021.c
> @@ -102,7 +102,7 @@ static ssize_t show_in_input(struct device *dev, struct device_attribute *attr,
> return sprintf(buf, "%d\n", in_input);
> }
>
> -static DEVICE_ATTR(in0_input, S_IRUGO, show_in_input, NULL);
> +static DEVICE_ATTR(in0_input, 0444, show_in_input, NULL);
>
> static int mcp3021_probe(struct i2c_client *client,
> const struct i2c_device_id *id)