RE: question about sound/soc/intel/boards/mfld_machine.c

From: Jie, Yang
Date: Sun Nov 20 2016 - 20:50:05 EST


> -----Original Message-----
> From: Julia Lawall [mailto:julia.lawall@xxxxxxx]
> Sent: Sunday, November 20, 2016 1:34 AM
> To: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; perex@xxxxxxxx;
> tiwai@xxxxxxxx; Jie, Yang <yang.jie@xxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: question about sound/soc/intel/boards/mfld_machine.c
>
> Hello,
>
> I wonder if the file sound/soc/intel/boards/mfld_machine.c is useful?
> Until:
>
> commit e56c72d5f201044b14191c5b83a25e17f2d68ccf
> Author: Jie Yang <yang.jie@xxxxxxxxx>
> Date: Thu Apr 2 15:37:02 2015 +0800
>
> ASoC: Intel: create boards folder and move sst boards files in
>
> it was in the directory sound/soc/intel and mentioned in
> sound/soc/intel/Makefile. The above patch moved it to
> sound/soc/intel/boards/, but didn't adjust its Makefile entry. The patch:
>
> commit b97169da06992ef04081e66ed22bbdb23dbf6610
> Author: Jie Yang <yang.jie@xxxxxxxxx>
> Date: Thu Apr 2 15:37:04 2015 +0800
>
> ASoC: Intel: create atom folder and move atom platform files in
>
> removed it from sound/soc/intel/Makefile, but didn't move it anywhere.
> As far as I can tell, there is currently no make information for the file in the
> kernel.
>
> Should the file be dropped?

Thanks for reporting, Julia. I believe this is missed during the folder
restruction.

Hi Vinod, what do you think? If needed, I can add it to intel/Kconfig.

Thanks,
~Keyon

>
> julia