Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace

[Chunyan Zhang]

On 18 November 2016 at 22:45, Alexander Shishkin
<alexander.shishkin@xxxxxxxxxxxxxxx> wrote:
> Chunyan Zhang <zhang.chunyan@xxxxxxxxxx> writes:
>
>> If CONFIG_STM_SOURCE_FTRACE is selected, Function trace data can be writen
>> to sink via STM, all functions that related to writing data packets to
>> STM should be marked 'notrace' to avoid being traced by Ftrace, otherwise
>> the program would stall into an endless loop.
>>
>> Signed-off-by: Chunyan Zhang <zhang.chunyan@xxxxxxxxxx>
>> Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>> ---
>>  drivers/hwtracing/coresight/coresight-stm.c |  2 +-
>>  drivers/hwtracing/intel_th/sth.c            | 11 +++++++----
>>  drivers/hwtracing/stm/core.c                |  7 ++++---
>>  drivers/hwtracing/stm/dummy_stm.c           |  2 +-
>>  include/linux/stm.h                         |  4 ++--
>>  5 files changed, 15 insertions(+), 11 deletions(-)
>
> Quick nit: can you please split this one in 4: one for Coresight, one
> for Intel TH, one for stm/dummy and one for stm/core?

Sure, will do.

>
> I'd like to keep the bisectability. Otherwise, this is fine by me:
>
> Acked-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>

Thanks,
Chunyan

>
> Regards,
> --
> Alex