Re: [PATCH v3 0/2] Ajust lockdep static allocations for sparc

From: Ingo Molnar
Date: Mon Nov 21 2016 - 02:17:08 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Fri, Nov 18, 2016 at 02:34:07PM -0500, David Miller wrote:
> > From: Babu Moger <babu.moger@xxxxxxxxxx>
> > Date: Tue, 27 Sep 2016 12:33:26 -0700
> >
> > > These patches limit the static allocations for lockdep data structures
> > > used for debugging locking correctness. For sparc, all the kernel's code,
> > > data, and bss, must have locked translations in the TLB so that we don't
> > > get TLB misses on kernel code and data. Current sparc chips have 8 TLB
> > > entries available that may be locked down, and with a 4mb page size,
> > > this gives a maximum of 32MB. With PROVE_LOCKING we could go over this
> > > limit and cause system boot-up problems. These patches limit the static
> > > allocations so that everything fits in current required size limit.
> > >
> > > patch 1 : Adds new config parameter CONFIG_PROVE_LOCKING_SMALL
> > > Patch 2 : Adjusts the sizes based on the new config parameter
> > >
> > > v2-> v3:
> > > Some more comments from Sam Ravnborg and Peter Zijlstra.
> > > Defined PROVE_LOCKING_SMALL as invisible and moved the selection to
> > > arch/sparc/Kconfig.
> > >
> > > v1-> v2:
> > > As suggested by Peter Zijlstra, keeping the default as is.
> > > Introduced new config variable CONFIG_PROVE_LOCKING_SMALL
> > > to handle sparc specific case.
> > >
> > > v0:
> > > Initial revision.
> >
> > Series applied, thanks.
>
> Heh, I was only waiting for an ACK from you, but this works too :-)

Works for me too - as usual davem is fantastic in terms of efficient patch flow :)

Thanks,

Ingo