Re: [PATCH v3 5/7] iio: multiplexer: new iio category and iio-mux driver

From: kbuild test robot
Date: Mon Nov 21 2016 - 09:33:36 EST

Hi Peter,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.9-rc6]
[cannot apply to next-20161117]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Peter-Rosin/mux-controller-abstraction-and-iio-i2c-muxes/20161121-215311
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

drivers/iio/multiplexer/iio-mux.c: In function 'mux_read_avail':
>> drivers/iio/multiplexer/iio-mux.c:134:9: error: implicit declaration of function 'iio_read_avail_channel_raw' [-Werror=implicit-function-declaration]
ret = iio_read_avail_channel_raw(mux->parent, vals, length);
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/multiplexer/iio-mux.c: At top level:
>> drivers/iio/multiplexer/iio-mux.c:174:2: error: unknown field 'read_avail' specified in initializer
.read_avail = mux_read_avail,
^
>> drivers/iio/multiplexer/iio-mux.c:174:16: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.read_avail = mux_read_avail,
^~~~~~~~~~~~~~
drivers/iio/multiplexer/iio-mux.c:174:16: note: (near initialization for 'mux_info.read_raw_multi')
drivers/iio/multiplexer/iio-mux.c: In function 'mux_configure_channel':
>> drivers/iio/multiplexer/iio-mux.c:267:6: error: implicit declaration of function 'iio_channel_has_available' [-Werror=implicit-function-declaration]
if (iio_channel_has_available(pchan, IIO_CHAN_INFO_RAW))
^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/multiplexer/iio-mux.c:268:7: error: 'struct iio_chan_spec' has no member named 'info_mask_separate_available'; did you mean 'info_mask_separate'?
chan->info_mask_separate_available |= BIT(IIO_CHAN_INFO_RAW);
^~
cc1: some warnings being treated as errors

vim +/iio_read_avail_channel_raw +134 drivers/iio/multiplexer/iio-mux.c

128 if (ret < 0)
129 return ret;
130
131 switch (mask) {
132 case IIO_CHAN_INFO_RAW:
133 *type = IIO_VAL_INT;
> 134 ret = iio_read_avail_channel_raw(mux->parent, vals, length);
135 break;
136
137 default:
138 ret = -EINVAL;
139 }
140
141 iio_mux_deselect(mux);
142
143 return ret;
144 }
145
146 static int mux_write_raw(struct iio_dev *indio_dev,
147 struct iio_chan_spec const *chan,
148 int val, int val2, long mask)
149 {
150 struct mux *mux = iio_priv(indio_dev);
151 int idx = chan - mux->chan;
152 int ret;
153
154 ret = iio_mux_select(mux, idx);
155 if (ret < 0)
156 return ret;
157
158 switch (mask) {
159 case IIO_CHAN_INFO_RAW:
160 ret = iio_write_channel_raw(mux->parent, val);
161 break;
162
163 default:
164 ret = -EINVAL;
165 }
166
167 iio_mux_deselect(mux);
168
169 return ret;
170 }
171
172 static const struct iio_info mux_info = {
173 .read_raw = mux_read_raw,
> 174 .read_avail = mux_read_avail,
175 .write_raw = mux_write_raw,
176 .driver_module = THIS_MODULE,
177 };
178
179 static ssize_t mux_read_ext_info(struct iio_dev *indio_dev, uintptr_t private,
180 struct iio_chan_spec const *chan, char *buf)
181 {
182 struct mux *mux = iio_priv(indio_dev);
183 int idx = chan - mux->chan;
184 ssize_t ret;
185
186 ret = iio_mux_select(mux, idx);
187 if (ret < 0)
188 return ret;
189
190 ret = iio_read_channel_ext_info(mux->parent,
191 mux->ext_info[private].name,
192 buf);
193
194 iio_mux_deselect(mux);
195
196 return ret;
197 }
198
199 static ssize_t mux_write_ext_info(struct iio_dev *indio_dev, uintptr_t private,
200 struct iio_chan_spec const *chan,
201 const char *buf, size_t len)
202 {
203 struct device *dev = indio_dev->dev.parent;
204 struct mux *mux = iio_priv(indio_dev);
205 int idx = chan - mux->chan;
206 char *new;
207 ssize_t ret;
208
209 ret = iio_mux_select(mux, idx);
210 if (ret < 0)
211 return ret;
212
213 new = devm_kmemdup(dev, buf, len + 1, GFP_KERNEL);
214 if (!new) {
215 iio_mux_deselect(mux);
216 return -ENOMEM;
217 }
218
219 new[len] = 0;
220
221 ret = iio_write_channel_ext_info(mux->parent,
222 mux->ext_info[private].name,
223 buf, len);
224 if (ret < 0) {
225 iio_mux_deselect(mux);
226 devm_kfree(dev, new);
227 return ret;
228 }
229
230 devm_kfree(dev, mux->child[idx].ext_info_cache[private].data);
231 mux->child[idx].ext_info_cache[private].data = new;
232 mux->child[idx].ext_info_cache[private].size = len;
233
234 iio_mux_deselect(mux);
235
236 return ret;
237 }
238
239 static int mux_configure_channel(struct device *dev, struct mux *mux,
240 struct device_node *child_np, int idx)
241 {
242 struct mux_child *child = &mux->child[idx];
243 struct iio_chan_spec *chan = &mux->chan[idx];
244 struct iio_chan_spec const *pchan = mux->parent->channel;
245 u32 state;
246 char *page = NULL;
247 int num_ext_info;
248 int i;
249 int ret;
250
251 chan->indexed = 1;
252 chan->output = pchan->output;
253 chan->datasheet_name = child_np->name;
254 chan->ext_info = mux->ext_info;
255
256 ret = iio_get_channel_type(mux->parent, &chan->type);
257 if (ret < 0) {
258 dev_err(dev, "failed to get parent channel type\n");
259 return ret;
260 }
261
262 if (iio_channel_has_info(pchan, IIO_CHAN_INFO_RAW))
263 chan->info_mask_separate |= BIT(IIO_CHAN_INFO_RAW);
264 if (iio_channel_has_info(pchan, IIO_CHAN_INFO_SCALE))
265 chan->info_mask_separate |= BIT(IIO_CHAN_INFO_SCALE);
266
> 267 if (iio_channel_has_available(pchan, IIO_CHAN_INFO_RAW))
> 268 chan->info_mask_separate_available |= BIT(IIO_CHAN_INFO_RAW);
269
270 ret = of_property_read_u32(child_np, "reg", &state);
271 if (ret < 0) {

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip